From: tb <tb@openbsd.org>
Date: Thu, 21 Oct 2021 08:38:11 +0000 (+0000)
Subject: Eliminate a dead assignment and a weird cast. Adjust a comment to
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=1b7b92c568c4df138ea51fdead23b7ae04d5125a;p=openbsd

Eliminate a dead assignment and a weird cast. Adjust a comment to
reality while there.

ok jsing
---

diff --git a/lib/libtls/tls_client.c b/lib/libtls/tls_client.c
index c45684dbb46..1629697f8ac 100644
--- a/lib/libtls/tls_client.c
+++ b/lib/libtls/tls_client.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tls_client.c,v 1.47 2021/06/01 20:26:11 tb Exp $ */
+/* $OpenBSD: tls_client.c,v 1.48 2021/10/21 08:38:11 tb Exp $ */
 /*
  * Copyright (c) 2014 Joel Sing <jsing@openbsd.org>
  *
@@ -74,11 +74,8 @@ tls_connect_servername(struct tls *ctx, const char *host, const char *port,
 		goto err;
 	}
 
-	/*
-	 * If port is NULL try to extract a port from the specified host,
-	 * otherwise use the default.
-	 */
-	if ((p = (char *)port) == NULL) {
+	/* If port is NULL, try to extract a port from the specified host. */
+	if (port == NULL) {
 		ret = tls_host_port(host, &hs, &ps);
 		if (ret == -1) {
 			tls_set_errorx(ctx, "memory allocation failure");