From: deraadt <deraadt@openbsd.org>
Date: Sun, 18 Oct 2015 01:53:31 +0000 (+0000)
Subject: TIOCSTI and TIOCSCTTY; oops got the condition backwards.
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=1b150eae18fba81f3f15b3ed23431cb06ac69bff;p=openbsd

TIOCSTI and TIOCSCTTY; oops got the condition backwards.
---

diff --git a/sys/kern/kern_pledge.c b/sys/kern/kern_pledge.c
index 5ae8213d589..3d1fa59be00 100644
--- a/sys/kern/kern_pledge.c
+++ b/sys/kern/kern_pledge.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: kern_pledge.c,v 1.50 2015/10/18 01:07:19 doug Exp $	*/
+/*	$OpenBSD: kern_pledge.c,v 1.51 2015/10/18 01:53:31 deraadt Exp $	*/
 
 /*
  * Copyright (c) 2015 Nicholas Marriott <nicm@openbsd.org>
@@ -1069,12 +1069,12 @@ pledge_ioctl_check(struct proc *p, long com, void *v)
 			return (0);
 #endif /* NPTY > 0 */
 		case TIOCSTI:		/* ksh? csh? */
-			if ((p->p_p->ps_pledge & PLEDGE_PROC) == 0 &&
+			if ((p->p_p->ps_pledge & PLEDGE_PROC) &&
 			    fp->f_type == DTYPE_VNODE && (vp->v_flag & VISTTY))
 				return (0);
 			break;
 		case TIOCSCTTY:		/* tmux etc */
-			if ((p->p_p->ps_pledge & PLEDGE_ID) == 0 &&
+			if ((p->p_p->ps_pledge & PLEDGE_ID) &&
 			    fp->f_type == DTYPE_VNODE && (vp->v_flag & VISTTY))
 				return (0);
 			break;