From: patrick Date: Tue, 22 Jun 2021 16:36:59 +0000 (+0000) Subject: bwfm(4) on PCI isn't really MPSAFE, and I'm not sure how this flag X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=14484aca4b0065034e6c7e5c52fa876266119155;p=openbsd bwfm(4) on PCI isn't really MPSAFE, and I'm not sure how this flag even got there in the first place. I've been wondering why I have seen a bit of mbuf corruption here and there since I put the bwfm(4) M.2 PCIe card into my arm64 machine. Well, duh. --- diff --git a/sys/dev/pci/if_bwfm_pci.c b/sys/dev/pci/if_bwfm_pci.c index 96f24c06247..949df27b899 100644 --- a/sys/dev/pci/if_bwfm_pci.c +++ b/sys/dev/pci/if_bwfm_pci.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_bwfm_pci.c,v 1.51 2021/02/26 12:33:59 patrick Exp $ */ +/* $OpenBSD: if_bwfm_pci.c,v 1.52 2021/06/22 16:36:59 patrick Exp $ */ /* * Copyright (c) 2010-2016 Broadcom Corporation * Copyright (c) 2017 Patrick Wildt @@ -376,7 +376,7 @@ bwfm_pci_attach(struct device *parent, struct device *self, void *aux) } intrstr = pci_intr_string(pa->pa_pc, ih); - sc->sc_ih = pci_intr_establish(pa->pa_pc, ih, IPL_NET | IPL_MPSAFE, + sc->sc_ih = pci_intr_establish(pa->pa_pc, ih, IPL_NET, bwfm_pci_intr, sc, DEVNAME(sc)); if (sc->sc_ih == NULL) { printf(": couldn't establish interrupt");