From: jmatthew Date: Sat, 19 Apr 2014 05:05:43 +0000 (+0000) Subject: move scsi_xs_put after checks that use fields in the xs X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=119b30c9bb153194fb681075fb458bd98e03d898;p=openbsd move scsi_xs_put after checks that use fields in the xs ok dlg@ --- diff --git a/sys/scsi/mpath_emc.c b/sys/scsi/mpath_emc.c index d7ace5d8f12..5e646bd91e2 100644 --- a/sys/scsi/mpath_emc.c +++ b/sys/scsi/mpath_emc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mpath_emc.c,v 1.18 2014/04/19 05:00:06 dlg Exp $ */ +/* $OpenBSD: mpath_emc.c,v 1.19 2014/04/19 05:05:43 jmatthew Exp $ */ /* * Copyright (c) 2011 David Gwynne @@ -246,13 +246,13 @@ emc_status_done(struct scsi_xfer *xs) struct emc_vpd_sp_info *pg = sc->sc_pg; int status = MPATH_S_UNKNOWN; - scsi_xs_put(xs); - if (xs->error == XS_NOERROR) { status = (pg->lun_state == EMC_SP_INFO_LUN_STATE_OWNED) ? MPATH_S_ACTIVE : MPATH_S_PASSIVE; } + scsi_xs_put(xs); + mpath_path_status(&sc->sc_path, status); }