From: tb <tb@openbsd.org>
Date: Fri, 7 Apr 2023 22:22:10 +0000 (+0000)
Subject: bn_test: rand_neg() is not only one of the most stupidly named functions
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=0f386146650e9a06aabf7f3c3165f2f04de08dbb;p=openbsd

bn_test: rand_neg() is not only one of the most stupidly named functions
in the entire code base it also has a few parentheses too many
---

diff --git a/regress/lib/libcrypto/bn/bn_test.c b/regress/lib/libcrypto/bn/bn_test.c
index 068d93fafeb..93c719e7ff1 100644
--- a/regress/lib/libcrypto/bn/bn_test.c
+++ b/regress/lib/libcrypto/bn/bn_test.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: bn_test.c,v 1.5 2023/04/07 22:18:42 tb Exp $	*/
+/*	$OpenBSD: bn_test.c,v 1.6 2023/04/07 22:22:10 tb Exp $	*/
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -2579,7 +2579,7 @@ rand_neg(void)
 	static unsigned int neg = 0;
 	static int sign[8] = { 0, 0, 0, 1, 1, 0, 1, 1 };
 
-	return (sign[(neg++) % 8]);
+	return sign[neg++ % 8];
 }
 
 int