From: espie <espie@openbsd.org>
Date: Mon, 16 May 2022 15:54:04 +0000 (+0000)
Subject: document failed experiment
X-Git-Url: http://artulab.com/gitweb/?a=commitdiff_plain;h=02e7a1dd1713b6198756a0fea395b53bbae4a3d3;p=openbsd

document failed experiment
---

diff --git a/usr.sbin/pkg_add/OpenBSD/PackageRepository/Cache.pm b/usr.sbin/pkg_add/OpenBSD/PackageRepository/Cache.pm
index fe851f7e588..97467103259 100644
--- a/usr.sbin/pkg_add/OpenBSD/PackageRepository/Cache.pm
+++ b/usr.sbin/pkg_add/OpenBSD/PackageRepository/Cache.pm
@@ -1,5 +1,5 @@
 # ex:ts=8 sw=4:
-# $OpenBSD: Cache.pm,v 1.8 2022/05/12 04:41:43 espie Exp $
+# $OpenBSD: Cache.pm,v 1.9 2022/05/16 15:54:04 espie Exp $
 #
 # Copyright (c) 2022 Marc Espie <espie@openbsd.org>
 #
@@ -84,6 +84,10 @@ sub prime_update_info_cache
 		$total));
 	my $done = 0;
 	my $oldname = ""; 
+	# This can't go much faster, I've tried splitting the params
+	# and running several locate(1) in //, but this yields negligible
+	# gains for a lot of added complexity (reduced from 18 to 14 seconds
+	# on my usual package install).
 	open my $fh, "-|", $self->pipe_locate(map { "$_-[0-9]*"} @list) 
 	    or $state->fatal("Can't run locate: #1", $!);
 	while (<$fh>) {