FC3416 section 4.2.1 (and others) tells us that if an error occurs the

varbindlist in the response must be identical to the original request.

OK tb@

diff --git a/usr.sbin/snmpd/application.c b/usr.sbin/snmpd/application.c
index 3f58090..52aa34d 100644 (file)
--- a/usr.sbin/snmpd/application.c
+++ b/usr.sbin/snmpd/application.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: application.c,v 1.23 2023/10/24 14:19:44 martijn Exp $        */
+/*     $OpenBSD: application.c,v 1.24 2023/10/24 14:21:58 martijn Exp $        */
 
 /*
  * Copyright (c) 2021 Martijn van Duren <martijn@openbsd.org>
@@ -1185,6 +1185,9 @@ appl_varbind_valid(struct appl_varbind *varbind,
        int cmp;
        int eomv = 0;
 
+       if (null)
+               next = 0;
+
        if (varbind->av_value == NULL) {
                if (!null) {
                        *errstr = "missing value";