The argument to ctype functions must be EOF or representable as an
authorflorian <florian@openbsd.org>
Thu, 15 Dec 2022 08:07:03 +0000 (08:07 +0000)
committerflorian <florian@openbsd.org>
Thu, 15 Dec 2022 08:07:03 +0000 (08:07 +0000)
unsigned char.

Casting to int is particularly useless because that's what the
compiler already does. We need to prevent sign extension, not write
down that we want sign extension.

OK deraadt, kn, miod, op

usr.sbin/ocspcheck/http.c

index 1669105..82a504a 100644 (file)
@@ -1,4 +1,4 @@
-/*     $Id: http.c,v 1.15 2021/09/14 16:37:20 tb Exp $ */
+/*     $Id: http.c,v 1.16 2022/12/15 08:07:03 florian Exp $ */
 /*
  * Copyright (c) 2016 Kristaps Dzonsons <kristaps@bsd.lv>
  *
@@ -556,7 +556,7 @@ http_head_parse(const struct http *http, struct httpxfer *trans, size_t *sz)
                }
 
                *ccp++ = '\0';
-               while (isspace((int)*ccp))
+               while (isspace((unsigned char)*ccp))
                        ccp++;
                h[hsz].key = cp;
                h[hsz++].val = ccp;