Remove redundant attrib_clear in upload_dir_internal. The subsequent
authordtucker <dtucker@openbsd.org>
Fri, 3 Sep 2021 05:12:25 +0000 (05:12 +0000)
committerdtucker <dtucker@openbsd.org>
Fri, 3 Sep 2021 05:12:25 +0000 (05:12 +0000)
call to stat_to_attrib clears the struct as its first step anyway.
From pmeinhardt via github PR#220, ok djm@

usr.bin/ssh/sftp-client.c

index 8667475..ffd6d92 100644 (file)
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp-client.c,v 1.154 2021/08/09 23:47:44 djm Exp $ */
+/* $OpenBSD: sftp-client.c,v 1.155 2021/09/03 05:12:25 dtucker Exp $ */
 /*
  * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
  *
@@ -2014,7 +2014,6 @@ upload_dir_internal(struct sftp_conn *conn, const char *src, const char *dst,
        if (print_flag && print_flag != SFTP_PROGRESS_ONLY)
                mprintf("Entering %s\n", src);
 
-       attrib_clear(&a);
        stat_to_attrib(&sb, &a);
        a.flags &= ~SSH2_FILEXFER_ATTR_SIZE;
        a.flags &= ~SSH2_FILEXFER_ATTR_UIDGID;