Add a comment that explains why build_addr_block_tests isn't const
authortb <tb@openbsd.org>
Thu, 6 Jan 2022 14:55:52 +0000 (14:55 +0000)
committertb <tb@openbsd.org>
Thu, 6 Jan 2022 14:55:52 +0000 (14:55 +0000)
regress/lib/libcrypto/x509/rfc3779/Makefile
regress/lib/libcrypto/x509/rfc3779/rfc3779.c

index 9786060..b0b23c5 100644 (file)
@@ -1,4 +1,4 @@
-#      $OpenBSD: Makefile,v 1.3 2021/12/24 14:00:11 tb Exp $
+#      $OpenBSD: Makefile,v 1.4 2022/01/06 14:55:52 tb Exp $
 
 .include "../../Makefile.inc"
 
@@ -6,6 +6,6 @@ PROG=   rfc3779
 LDADD= ${CRYPTO_INT}
 DPADD= ${LIBCRYPTO}
 WARNINGS=      Yes
-CFLAGS+=       -DLIBRESSL_CRYPTO_INTERNAL -DLIBRESSL_INTERNAL -Werror
+CFLAGS+=       -DLIBRESSL_CRYPTO_INTERNAL -DLIBRESSL_INTERNAL -Werror -g -O0
 
 .include <bsd.regress.mk>
index e6636bb..384d144 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: rfc3779.c,v 1.4 2022/01/06 09:46:05 tb Exp $ */
+/*     $OpenBSD: rfc3779.c,v 1.5 2022/01/06 14:55:52 tb Exp $ */
 /*
  * Copyright (c) 2021 Theo Buehler <tb@openbsd.org>
  *
@@ -471,6 +471,11 @@ struct build_addr_block_test_data {
        int                      afi_len;
 };
 
+/*
+ * This struct isn't const since the address arguments of
+ * X509v3_addr_add_{prefix,range}() aren't const and it's
+ * not worth working around this.
+ */
 struct build_addr_block_test_data build_addr_block_tests[] = {
        {
                .description = "RFC 3779, Appendix B, example 1",