Remove SUDO in proxy command wrapper. Anything that needs sudo is
authordtucker <dtucker@openbsd.org>
Thu, 2 Mar 2023 11:10:27 +0000 (11:10 +0000)
committerdtucker <dtucker@openbsd.org>
Thu, 2 Mar 2023 11:10:27 +0000 (11:10 +0000)
already run by it, and it breaks if root isn't in sudoers.

regress/usr.bin/ssh/test-exec.sh

index ad2007d..c01a262 100644 (file)
@@ -1,4 +1,4 @@
-#      $OpenBSD: test-exec.sh,v 1.97 2023/03/02 08:24:41 dtucker Exp $
+#      $OpenBSD: test-exec.sh,v 1.98 2023/03/02 11:10:27 dtucker Exp $
 #      Placed in the Public Domain.
 
 #SUDO=sudo
@@ -184,8 +184,8 @@ logfile="${TEST_SSH_LOGDIR}/\${timestamp}.ssh.\$\$.log"
 echo "Executing: ${SSH} \$@" log \${logfile} >>$TEST_REGRESS_LOGFILE
 echo "Executing: ${SSH} \$@" >>\${logfile}
 for i in "\$@";do shift;case "\$i" in -q):;; *) set -- "\$@" "\$i";;esac;done
-$SUDO rm -f $TEST_SSH_LOGFILE
-ln -s \${logfile} $TEST_SSH_LOGFILE
+rm -f $TEST_SSH_LOGFILE
+ln -f -s \${logfile} $TEST_SSH_LOGFILE
 exec ${SSH} -E\${logfile} "\$@"
 EOD
 
@@ -199,8 +199,8 @@ cat >$SSHDLOGWRAP <<EOD
 #!/bin/sh
 timestamp="\`$OBJ/timestamp\`"
 logfile="${TEST_SSH_LOGDIR}/\${timestamp}.sshd.\$\$.log"
-$SUDO rm -f $TEST_SSHD_LOGFILE
-ln -s \${logfile} $TEST_SSHD_LOGFILE
+rm -f $TEST_SSHD_LOGFILE
+ln -f -s \${logfile} $TEST_SSHD_LOGFILE
 echo "Executing: ${SSHD} \$@" log \${logfile} >>$TEST_REGRESS_LOGFILE
 echo "Executing: ${SSHD} \$@" >>\${logfile}
 exec ${SSHD} -E\${logfile} "\$@"