the return from asprintf does NOT include the space used by the

terminating \0 character. if i want to use it as a c string i have
to take that into account.

found by simon kuhnle who supplied a good bug report. prodded by deraadt@

diff --git a/usr.sbin/identd/identd.c b/usr.sbin/identd/identd.c
index 0cfef24..6e628e8 100644 (file)
--- a/usr.sbin/identd/identd.c
+++ b/usr.sbin/identd/identd.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: identd.c,v 1.23 2013/11/21 03:09:07 dlg Exp $ */
+/*     $OpenBSD: identd.c,v 1.24 2014/01/07 00:11:11 dlg Exp $ */
 
 /*
  * Copyright (c) 2013 David Gwynne <dlg@openbsd.org>
@@ -395,7 +395,7 @@ parent_rd(int fd, short events, void *arg)
                goto done;
        }
 
-       r->buflen = n;
+       r->buflen = n + 1;
 
 done:
        SIMPLEQ_INSERT_TAIL(&sc.parent.replies, r, entry);