challenge is an array, not a pointer, therefore cannot be NULL.
authormillert <millert@openbsd.org>
Thu, 27 Apr 2017 20:55:52 +0000 (20:55 +0000)
committermillert <millert@openbsd.org>
Thu, 27 Apr 2017 20:55:52 +0000 (20:55 +0000)
Quiets a clang warning.

libexec/login_radius/login_radius.c

index c797610..9b00f97 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: login_radius.c,v 1.8 2015/11/26 19:59:18 yasuoka Exp $        */
+/*     $OpenBSD: login_radius.c,v 1.9 2017/04/27 20:55:52 millert Exp $        */
 
 /*-
  * Copyright (c) 1996, 1997 Berkeley Software Design, Inc. All rights reserved.
@@ -183,7 +183,7 @@ main(int argc, char **argv)
            strcmp(service, "login") ? challenge : NULL, password, &emsg);
 
        if (c == 0) {
-               if (challenge == NULL || *challenge == '\0')
+               if (*challenge == '\0')
                        (void)fprintf(back, BI_AUTH "\n");
                else {
                        (void)fprintf(back, BI_VALUE " challenge %s\n",