drm/amd/display: Pass pwrseq inst for backlight and ABM

From Lewis Huang
71be0f674070a5ad54a1c4fb112bb2923b28ea50 in linux-6.6.y/6.6.13
b17ef04bf3a4346d66404454d6a646343ddc9749 in mainline linux

diff --git a/sys/dev/pci/drm/amd/display/dc/bios/bios_parser2.c b/sys/dev/pci/drm/amd/display/dc/bios/bios_parser2.c
index 518c567..bbf2a46 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/bios/bios_parser2.c
+++ b/sys/dev/pci/drm/amd/display/dc/bios/bios_parser2.c
@@ -1699,7 +1699,7 @@ static enum bp_result bios_parser_enable_disp_power_gating(
 static enum bp_result bios_parser_enable_lvtma_control(
        struct dc_bios *dcb,
        uint8_t uc_pwr_on,
-       uint8_t panel_instance,
+       uint8_t pwrseq_instance,
        uint8_t bypass_panel_control_wait)
 {
        struct bios_parser *bp = BP_FROM_DCB(dcb);
@@ -1707,7 +1707,7 @@ static enum bp_result bios_parser_enable_lvtma_control(
        if (!bp->cmd_tbl.enable_lvtma_control)
                return BP_RESULT_FAILURE;
 
-       return bp->cmd_tbl.enable_lvtma_control(bp, uc_pwr_on, panel_instance, bypass_panel_control_wait);
+       return bp->cmd_tbl.enable_lvtma_control(bp, uc_pwr_on, pwrseq_instance, bypass_panel_control_wait);
 }
 
 static bool bios_parser_is_accelerated_mode(

diff --git a/sys/dev/pci/drm/amd/display/dc/bios/command_table2.c b/sys/dev/pci/drm/amd/display/dc/bios/command_table2.c
index 90a02d7..ab0adab 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/bios/command_table2.c
+++ b/sys/dev/pci/drm/amd/display/dc/bios/command_table2.c
@@ -976,7 +976,7 @@ static unsigned int get_smu_clock_info_v3_1(struct bios_parser *bp, uint8_t id)
 static enum bp_result enable_lvtma_control(
        struct bios_parser *bp,
        uint8_t uc_pwr_on,
-       uint8_t panel_instance,
+       uint8_t pwrseq_instance,
        uint8_t bypass_panel_control_wait);
 
 static void init_enable_lvtma_control(struct bios_parser *bp)
@@ -989,7 +989,7 @@ static void init_enable_lvtma_control(struct bios_parser *bp)
 static void enable_lvtma_control_dmcub(
        struct dc_dmub_srv *dmcub,
        uint8_t uc_pwr_on,
-       uint8_t panel_instance,
+       uint8_t pwrseq_instance,
        uint8_t bypass_panel_control_wait)
 {
 
@@ -1002,8 +1002,8 @@ static void enable_lvtma_control_dmcub(
                        DMUB_CMD__VBIOS_LVTMA_CONTROL;
        cmd.lvtma_control.data.uc_pwr_action =
                        uc_pwr_on;
-       cmd.lvtma_control.data.panel_inst =
-                       panel_instance;
+       cmd.lvtma_control.data.pwrseq_inst =
+                       pwrseq_instance;
        cmd.lvtma_control.data.bypass_panel_control_wait =
                        bypass_panel_control_wait;
        dm_execute_dmub_cmd(dmcub->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
@@ -1012,7 +1012,7 @@ static void enable_lvtma_control_dmcub(
 static enum bp_result enable_lvtma_control(
        struct bios_parser *bp,
        uint8_t uc_pwr_on,
-       uint8_t panel_instance,
+       uint8_t pwrseq_instance,
        uint8_t bypass_panel_control_wait)
 {
        enum bp_result result = BP_RESULT_FAILURE;
@@ -1021,7 +1021,7 @@ static enum bp_result enable_lvtma_control(
            bp->base.ctx->dc->debug.dmub_command_table) {
                enable_lvtma_control_dmcub(bp->base.ctx->dmub_srv,
                                uc_pwr_on,
-                               panel_instance,
+                               pwrseq_instance,
                                bypass_panel_control_wait);
                return BP_RESULT_OK;
        }

diff --git a/sys/dev/pci/drm/amd/display/dc/bios/command_table2.h b/sys/dev/pci/drm/amd/display/dc/bios/command_table2.h
index b6d09bf..41c8c01 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/bios/command_table2.h
+++ b/sys/dev/pci/drm/amd/display/dc/bios/command_table2.h
@@ -96,7 +96,7 @@ struct cmd_tbl {
                        struct bios_parser *bp, uint8_t id);
        enum bp_result (*enable_lvtma_control)(struct bios_parser *bp,
                        uint8_t uc_pwr_on,
-                       uint8_t panel_instance,
+                       uint8_t pwrseq_instance,
                        uint8_t bypass_panel_control_wait);
 };
 

diff --git a/sys/dev/pci/drm/amd/display/dc/dc_bios_types.h b/sys/dev/pci/drm/amd/display/dc/dc_bios_types.h
index be9aa1a..26940d9 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dc_bios_types.h
+++ b/sys/dev/pci/drm/amd/display/dc/dc_bios_types.h
@@ -140,7 +140,7 @@ struct dc_vbios_funcs {
        enum bp_result (*enable_lvtma_control)(
                struct dc_bios *bios,
                uint8_t uc_pwr_on,
-               uint8_t panel_instance,
+               uint8_t pwrseq_instance,
                uint8_t bypass_panel_control_wait);
 
        enum bp_result (*get_soc_bb_info)(

diff --git a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm.c b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm.c
index d3e6544..930fd92 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm.c
+++ b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm.c
@@ -145,7 +145,11 @@ static bool dmub_abm_save_restore_ex(
        return ret;
 }
 
-static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t option, uint32_t panel_inst)
+static bool dmub_abm_set_pipe_ex(struct abm *abm,
+               uint32_t otg_inst,
+               uint32_t option,
+               uint32_t panel_inst,
+               uint32_t pwrseq_inst)
 {
        bool ret = false;
        unsigned int feature_support;
@@ -153,7 +157,7 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
        feature_support = abm_feature_support(abm, panel_inst);
 
        if (feature_support == ABM_LCD_SUPPORT)
-               ret = dmub_abm_set_pipe(abm, otg_inst, option, panel_inst);
+               ret = dmub_abm_set_pipe(abm, otg_inst, option, panel_inst, pwrseq_inst);
 
        return ret;
 }

diff --git a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.c b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.c
index 592a8f7..42c802a 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.c
+++ b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.c
@@ -254,7 +254,11 @@ bool dmub_abm_save_restore(
        return true;
 }
 
-bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t option, uint32_t panel_inst)
+bool dmub_abm_set_pipe(struct abm *abm,
+               uint32_t otg_inst,
+               uint32_t option,
+               uint32_t panel_inst,
+               uint32_t pwrseq_inst)
 {
        union dmub_rb_cmd cmd;
        struct dc_context *dc = abm->ctx;
@@ -264,6 +268,7 @@ bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t option, uint
        cmd.abm_set_pipe.header.type = DMUB_CMD__ABM;
        cmd.abm_set_pipe.header.sub_type = DMUB_CMD__ABM_SET_PIPE;
        cmd.abm_set_pipe.abm_set_pipe_data.otg_inst = otg_inst;
+       cmd.abm_set_pipe.abm_set_pipe_data.pwrseq_inst = pwrseq_inst;
        cmd.abm_set_pipe.abm_set_pipe_data.set_pipe_option = option;
        cmd.abm_set_pipe.abm_set_pipe_data.panel_inst = panel_inst;
        cmd.abm_set_pipe.abm_set_pipe_data.ramping_boundary = ramping_boundary;

diff --git a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.h b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.h
index 853564d..07ea6c8 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.h
+++ b/sys/dev/pci/drm/amd/display/dc/dce/dmub_abm_lcd.h
@@ -44,7 +44,7 @@ bool dmub_abm_save_restore(
                struct dc_context *dc,
                unsigned int panel_inst,
                struct abm_save_restore *pData);
-bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t option, uint32_t panel_inst);
+bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t option, uint32_t panel_inst, uint32_t pwrseq_inst);
 bool dmub_abm_set_backlight_level(struct abm *abm,
                unsigned int backlight_pwm_u16_16,
                unsigned int frame_ramp,

diff --git a/sys/dev/pci/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/sys/dev/pci/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 6054b8d..a95b2fe 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/sys/dev/pci/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -788,7 +788,7 @@ void dce110_edp_power_control(
        struct dc_context *ctx = link->ctx;
        struct bp_transmitter_control cntl = { 0 };
        enum bp_result bp_result;
-       uint8_t panel_instance;
+       uint8_t pwrseq_instance;
 
 
        if (dal_graphics_object_id_get_connector_id(link->link_enc->connector)
@@ -871,7 +871,7 @@ void dce110_edp_power_control(
                cntl.coherent = false;
                cntl.lanes_number = LANE_COUNT_FOUR;
                cntl.hpd_sel = link->link_enc->hpd_source;
-               panel_instance = link->panel_cntl->inst;
+               pwrseq_instance = link->panel_cntl->pwrseq_inst;
 
                if (ctx->dc->ctx->dmub_srv &&
                                ctx->dc->debug.dmub_command_table) {
@@ -879,11 +879,11 @@ void dce110_edp_power_control(
                        if (cntl.action == TRANSMITTER_CONTROL_POWER_ON) {
                                bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
                                                LVTMA_CONTROL_POWER_ON,
-                                               panel_instance, link->link_powered_externally);
+                                               pwrseq_instance, link->link_powered_externally);
                        } else {
                                bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
                                                LVTMA_CONTROL_POWER_OFF,
-                                               panel_instance, link->link_powered_externally);
+                                               pwrseq_instance, link->link_powered_externally);
                        }
                }
 
@@ -954,7 +954,7 @@ void dce110_edp_backlight_control(
 {
        struct dc_context *ctx = link->ctx;
        struct bp_transmitter_control cntl = { 0 };
-       uint8_t panel_instance;
+       uint8_t pwrseq_instance;
        unsigned int pre_T11_delay = OLED_PRE_T11_DELAY;
        unsigned int post_T7_delay = OLED_POST_T7_DELAY;
 
@@ -1007,7 +1007,7 @@ void dce110_edp_backlight_control(
         */
        /* dc_service_sleep_in_milliseconds(50); */
                /*edp 1.2*/
-       panel_instance = link->panel_cntl->inst;
+       pwrseq_instance = link->panel_cntl->pwrseq_inst;
 
        if (cntl.action == TRANSMITTER_CONTROL_BACKLIGHT_ON) {
                if (!link->dc->config.edp_no_power_sequencing)
@@ -1032,11 +1032,11 @@ void dce110_edp_backlight_control(
                if (cntl.action == TRANSMITTER_CONTROL_BACKLIGHT_ON)
                        ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
                                        LVTMA_CONTROL_LCD_BLON,
-                                       panel_instance, link->link_powered_externally);
+                                       pwrseq_instance, link->link_powered_externally);
                else
                        ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
                                        LVTMA_CONTROL_LCD_BLOFF,
-                                       panel_instance, link->link_powered_externally);
+                                       pwrseq_instance, link->link_powered_externally);
        }
 
        link_transmitter_control(ctx->dc_bios, &cntl);

diff --git a/sys/dev/pci/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/sys/dev/pci/drm/amd/display/dc/dcn21/dcn21_hwseq.c
index 43463d0..f99b1bc 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dcn21/dcn21_hwseq.c
+++ b/sys/dev/pci/drm/amd/display/dc/dcn21/dcn21_hwseq.c
@@ -137,7 +137,8 @@ void dcn21_PLAT_58856_wa(struct dc_state *context, struct pipe_ctx *pipe_ctx)
        pipe_ctx->stream->dpms_off = true;
 }
 
-static bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t option, uint32_t panel_inst)
+static bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst,
+               uint32_t option, uint32_t panel_inst, uint32_t pwrseq_inst)
 {
        union dmub_rb_cmd cmd;
        struct dc_context *dc = abm->ctx;
@@ -147,6 +148,7 @@ static bool dmub_abm_set_pipe(struct abm *abm, uint32_t otg_inst, uint32_t optio
        cmd.abm_set_pipe.header.type = DMUB_CMD__ABM;
        cmd.abm_set_pipe.header.sub_type = DMUB_CMD__ABM_SET_PIPE;
        cmd.abm_set_pipe.abm_set_pipe_data.otg_inst = otg_inst;
+       cmd.abm_set_pipe.abm_set_pipe_data.pwrseq_inst = pwrseq_inst;
        cmd.abm_set_pipe.abm_set_pipe_data.set_pipe_option = option;
        cmd.abm_set_pipe.abm_set_pipe_data.panel_inst = panel_inst;
        cmd.abm_set_pipe.abm_set_pipe_data.ramping_boundary = ramping_boundary;
@@ -179,7 +181,6 @@ void dcn21_set_abm_immediate_disable(struct pipe_ctx *pipe_ctx)
        struct abm *abm = pipe_ctx->stream_res.abm;
        uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
        struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
-
        struct dmcu *dmcu = pipe_ctx->stream->ctx->dc->res_pool->dmcu;
 
        if (dmcu) {
@@ -190,9 +191,13 @@ void dcn21_set_abm_immediate_disable(struct pipe_ctx *pipe_ctx)
        if (abm && panel_cntl) {
                if (abm->funcs && abm->funcs->set_pipe_ex) {
                        abm->funcs->set_pipe_ex(abm, otg_inst, SET_ABM_PIPE_IMMEDIATELY_DISABLE,
-                       panel_cntl->inst);
+                                       panel_cntl->inst, panel_cntl->pwrseq_inst);
                } else {
-                       dmub_abm_set_pipe(abm, otg_inst, SET_ABM_PIPE_IMMEDIATELY_DISABLE, panel_cntl->inst);
+                               dmub_abm_set_pipe(abm,
+                                               otg_inst,
+                                               SET_ABM_PIPE_IMMEDIATELY_DISABLE,
+                                               panel_cntl->inst,
+                                               panel_cntl->pwrseq_inst);
                }
                panel_cntl->funcs->store_backlight_level(panel_cntl);
        }
@@ -212,9 +217,16 @@ void dcn21_set_pipe(struct pipe_ctx *pipe_ctx)
 
        if (abm && panel_cntl) {
                if (abm->funcs && abm->funcs->set_pipe_ex) {
-                       abm->funcs->set_pipe_ex(abm, otg_inst, SET_ABM_PIPE_NORMAL, panel_cntl->inst);
+                       abm->funcs->set_pipe_ex(abm,
+                                       otg_inst,
+                                       SET_ABM_PIPE_NORMAL,
+                                       panel_cntl->inst,
+                                       panel_cntl->pwrseq_inst);
                } else {
-                       dmub_abm_set_pipe(abm, otg_inst, SET_ABM_PIPE_NORMAL, panel_cntl->inst);
+                               dmub_abm_set_pipe(abm, otg_inst,
+                                               SET_ABM_PIPE_NORMAL,
+                                               panel_cntl->inst,
+                                               panel_cntl->pwrseq_inst);
                }
        }
 }
@@ -237,9 +249,17 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
 
                if (abm && panel_cntl) {
                        if (abm->funcs && abm->funcs->set_pipe_ex) {
-                               abm->funcs->set_pipe_ex(abm, otg_inst, SET_ABM_PIPE_NORMAL, panel_cntl->inst);
+                               abm->funcs->set_pipe_ex(abm,
+                                               otg_inst,
+                                               SET_ABM_PIPE_NORMAL,
+                                               panel_cntl->inst,
+                                               panel_cntl->pwrseq_inst);
                        } else {
-                               dmub_abm_set_pipe(abm, otg_inst, SET_ABM_PIPE_NORMAL, panel_cntl->inst);
+                                       dmub_abm_set_pipe(abm,
+                                                       otg_inst,
+                                                       SET_ABM_PIPE_NORMAL,
+                                                       panel_cntl->inst,
+                                                       panel_cntl->pwrseq_inst);
                        }
                }
        }

diff --git a/sys/dev/pci/drm/amd/display/dc/dcn31/dcn31_panel_cntl.c b/sys/dev/pci/drm/amd/display/dc/dcn31/dcn31_panel_cntl.c
index 217acd4..d849b1e 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/dcn31/dcn31_panel_cntl.c
+++ b/sys/dev/pci/drm/amd/display/dc/dcn31/dcn31_panel_cntl.c
@@ -50,7 +50,7 @@ static bool dcn31_query_backlight_info(struct panel_cntl *panel_cntl, union dmub
        cmd->panel_cntl.header.type = DMUB_CMD__PANEL_CNTL;
        cmd->panel_cntl.header.sub_type = DMUB_CMD__PANEL_CNTL_QUERY_BACKLIGHT_INFO;
        cmd->panel_cntl.header.payload_bytes = sizeof(cmd->panel_cntl.data);
-       cmd->panel_cntl.data.inst = dcn31_panel_cntl->base.inst;
+       cmd->panel_cntl.data.pwrseq_inst = dcn31_panel_cntl->base.pwrseq_inst;
 
        return dm_execute_dmub_cmd(dc_dmub_srv->ctx, cmd, DM_DMUB_WAIT_TYPE_WAIT_WITH_REPLY);
 }
@@ -78,7 +78,7 @@ static uint32_t dcn31_panel_cntl_hw_init(struct panel_cntl *panel_cntl)
        cmd.panel_cntl.header.type = DMUB_CMD__PANEL_CNTL;
        cmd.panel_cntl.header.sub_type = DMUB_CMD__PANEL_CNTL_HW_INIT;
        cmd.panel_cntl.header.payload_bytes = sizeof(cmd.panel_cntl.data);
-       cmd.panel_cntl.data.inst = dcn31_panel_cntl->base.inst;
+       cmd.panel_cntl.data.pwrseq_inst = dcn31_panel_cntl->base.pwrseq_inst;
        cmd.panel_cntl.data.bl_pwm_cntl = panel_cntl->stored_backlight_registers.BL_PWM_CNTL;
        cmd.panel_cntl.data.bl_pwm_period_cntl = panel_cntl->stored_backlight_registers.BL_PWM_PERIOD_CNTL;
        cmd.panel_cntl.data.bl_pwm_ref_div1 =
@@ -157,4 +157,5 @@ void dcn31_panel_cntl_construct(
        dcn31_panel_cntl->base.funcs = &dcn31_link_panel_cntl_funcs;
        dcn31_panel_cntl->base.ctx = init_data->ctx;
        dcn31_panel_cntl->base.inst = init_data->inst;
+       dcn31_panel_cntl->base.pwrseq_inst = init_data->pwrseq_inst;
 }

diff --git a/sys/dev/pci/drm/amd/display/dc/inc/hw/abm.h b/sys/dev/pci/drm/amd/display/dc/inc/hw/abm.h
index 33db15d..9f521cf 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/inc/hw/abm.h
+++ b/sys/dev/pci/drm/amd/display/dc/inc/hw/abm.h
@@ -64,7 +64,8 @@ struct abm_funcs {
        bool (*set_pipe_ex)(struct abm *abm,
                        unsigned int otg_inst,
                        unsigned int option,
-                       unsigned int panel_inst);
+                       unsigned int panel_inst,
+                       unsigned int pwrseq_inst);
 };
 
 #endif

diff --git a/sys/dev/pci/drm/amd/display/dc/inc/hw/panel_cntl.h b/sys/dev/pci/drm/amd/display/dc/inc/hw/panel_cntl.h
index 24af9d8..248adc1 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/inc/hw/panel_cntl.h
+++ b/sys/dev/pci/drm/amd/display/dc/inc/hw/panel_cntl.h
@@ -56,12 +56,14 @@ struct panel_cntl_funcs {
 struct panel_cntl_init_data {
        struct dc_context *ctx;
        uint32_t inst;
+       uint32_t pwrseq_inst;
 };
 
 struct panel_cntl {
        const struct panel_cntl_funcs *funcs;
        struct dc_context *ctx;
        uint32_t inst;
+       uint32_t pwrseq_inst;
        /* registers setting needs to be saved and restored at InitBacklight */
        struct panel_cntl_backlight_registers stored_backlight_registers;
 };

diff --git a/sys/dev/pci/drm/amd/display/dc/link/link_factory.c b/sys/dev/pci/drm/amd/display/dc/link/link_factory.c
index e406561..2c36686 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dc/link/link_factory.c
+++ b/sys/dev/pci/drm/amd/display/dc/link/link_factory.c
@@ -367,6 +367,27 @@ static enum transmitter translate_encoder_to_transmitter(
        }
 }
 
+static uint8_t translate_dig_inst_to_pwrseq_inst(struct dc_link *link)
+{
+       uint8_t pwrseq_inst = 0xF;
+
+       switch (link->eng_id) {
+       case ENGINE_ID_DIGA:
+               pwrseq_inst = 0;
+               break;
+       case ENGINE_ID_DIGB:
+               pwrseq_inst = 1;
+               break;
+       default:
+               DC_LOG_WARNING("Unsupported pwrseq engine id: %d!\n", link->eng_id);
+               ASSERT(false);
+               break;
+       }
+
+       return pwrseq_inst;
+}
+
+
 static void link_destruct(struct dc_link *link)
 {
        int i;
@@ -594,24 +615,6 @@ static bool construct_phy(struct dc_link *link,
        link->ddc_hw_inst =
                dal_ddc_get_line(get_ddc_pin(link->ddc));
 
-
-       if (link->dc->res_pool->funcs->panel_cntl_create &&
-               (link->link_id.id == CONNECTOR_ID_EDP ||
-                       link->link_id.id == CONNECTOR_ID_LVDS)) {
-               panel_cntl_init_data.ctx = dc_ctx;
-               panel_cntl_init_data.inst =
-                       panel_cntl_init_data.ctx->dc_edp_id_count;
-               link->panel_cntl =
-                       link->dc->res_pool->funcs->panel_cntl_create(
-                                                               &panel_cntl_init_data);
-               panel_cntl_init_data.ctx->dc_edp_id_count++;
-
-               if (link->panel_cntl == NULL) {
-                       DC_ERROR("Failed to create link panel_cntl!\n");
-                       goto panel_cntl_create_fail;
-               }
-       }
-
        enc_init_data.ctx = dc_ctx;
        bp_funcs->get_src_obj(dc_ctx->dc_bios, link->link_id, 0,
                              &enc_init_data.encoder);
@@ -642,6 +645,23 @@ static bool construct_phy(struct dc_link *link,
        link->dc->res_pool->dig_link_enc_count++;
 
        link->link_enc_hw_inst = link->link_enc->transmitter;
+
+       if (link->dc->res_pool->funcs->panel_cntl_create &&
+               (link->link_id.id == CONNECTOR_ID_EDP ||
+                       link->link_id.id == CONNECTOR_ID_LVDS)) {
+               panel_cntl_init_data.ctx = dc_ctx;
+               panel_cntl_init_data.inst = panel_cntl_init_data.ctx->dc_edp_id_count;
+               panel_cntl_init_data.pwrseq_inst = translate_dig_inst_to_pwrseq_inst(link);
+               link->panel_cntl =
+                       link->dc->res_pool->funcs->panel_cntl_create(
+                                                               &panel_cntl_init_data);
+               panel_cntl_init_data.ctx->dc_edp_id_count++;
+
+               if (link->panel_cntl == NULL) {
+                       DC_ERROR("Failed to create link panel_cntl!\n");
+                       goto panel_cntl_create_fail;
+               }
+       }
        for (i = 0; i < 4; i++) {
                if (bp_funcs->get_device_tag(dc_ctx->dc_bios,
                                             link->link_id, i,

diff --git a/sys/dev/pci/drm/amd/display/dmub/inc/dmub_cmd.h b/sys/dev/pci/drm/amd/display/dmub/inc/dmub_cmd.h
index 8b10e75..387a2c8 100644 (file)
--- a/sys/dev/pci/drm/amd/display/dmub/inc/dmub_cmd.h
+++ b/sys/dev/pci/drm/amd/display/dmub/inc/dmub_cmd.h
@@ -3303,6 +3303,16 @@ struct dmub_cmd_abm_set_pipe_data {
         * TODO: Remove.
         */
        uint8_t ramping_boundary;
+
+       /**
+        * PwrSeq HW Instance.
+        */
+       uint8_t pwrseq_inst;
+
+       /**
+        * Explicit padding to 4 byte boundary.
+        */
+       uint8_t pad[3];
 };
 
 /**
@@ -3717,7 +3727,7 @@ enum dmub_cmd_panel_cntl_type {
  * struct dmub_cmd_panel_cntl_data - Panel control data.
  */
 struct dmub_cmd_panel_cntl_data {
-       uint32_t inst; /**< panel instance */
+       uint32_t pwrseq_inst; /**< pwrseq instance */
        uint32_t current_backlight; /* in/out */
        uint32_t bl_pwm_cntl; /* in/out */
        uint32_t bl_pwm_period_cntl; /* in/out */
@@ -3744,7 +3754,7 @@ struct dmub_cmd_lvtma_control_data {
        uint8_t uc_pwr_action; /**< LVTMA_ACTION */
        uint8_t bypass_panel_control_wait;
        uint8_t reserved_0[2]; /**< For future use */
-       uint8_t panel_inst; /**< LVTMA control instance */
+       uint8_t pwrseq_inst; /**< LVTMA control instance */
        uint8_t reserved_1[3]; /**< For future use */
 };