Default REGRESS_FAIL_EARLY to yes

The current fail open behavior may be desirable in some circumstances,
but it is an unexpected and dangerous default since one expects some
kind of feedback when running a test suite. Currently failing tests are
only visible on inspecting the log, which led to unsuspecting people
missing failures several times in the past. Flip the default to fail
closed. For those that want to have the old behavior, it is easy enough
to set the variable to no.

Positive feedback job and schwarze
ok kn

diff --git a/share/mk/bsd.regress.mk b/share/mk/bsd.regress.mk
index 6f14dd1..1ab9e59 100644 (file)
--- a/share/mk/bsd.regress.mk
+++ b/share/mk/bsd.regress.mk
@@ -1,4 +1,4 @@
-# $OpenBSD: bsd.regress.mk,v 1.25 2022/12/09 09:30:54 tb Exp $
+# $OpenBSD: bsd.regress.mk,v 1.26 2023/09/15 07:13:35 tb Exp $
 # Documented in bsd.regress.mk(5)
 
 # No man pages for regression tests.
@@ -21,7 +21,7 @@ all: regress
 REGRESS_LOG?=/dev/null
 REGRESS_SKIP_TARGETS?=
 REGRESS_SKIP_SLOW?=no
-REGRESS_FAIL_EARLY?=no
+REGRESS_FAIL_EARLY?=yes
 
 .if ! ${REGRESS_LOG:M/*}
 ERRORS += "Fatal: REGRESS_LOG=${REGRESS_LOG} is not an absolute path"