Fix some KNF issues
authortb <tb@openbsd.org>
Tue, 29 Nov 2022 07:06:12 +0000 (07:06 +0000)
committertb <tb@openbsd.org>
Tue, 29 Nov 2022 07:06:12 +0000 (07:06 +0000)
Requested by claudio

lib/libcrypto/x509/x509_txt.c

index 8485aeb..58c0566 100644 (file)
@@ -1,4 +1,4 @@
-/* $OpenBSD: x509_txt.c,v 1.22 2022/11/29 07:03:40 tb Exp $ */
+/* $OpenBSD: x509_txt.c,v 1.23 2022/11/29 07:06:12 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -72,132 +72,131 @@ X509_verify_cert_error_string(long n)
 {
        switch ((int)n) {
        case X509_V_OK:
-               return("ok");
+               return "ok";
        case X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT:
-               return("unable to get issuer certificate");
+               return "unable to get issuer certificate";
        case X509_V_ERR_UNABLE_TO_GET_CRL:
-               return("unable to get certificate CRL");
+               return "unable to get certificate CRL";
        case X509_V_ERR_UNABLE_TO_DECRYPT_CERT_SIGNATURE:
-               return("unable to decrypt certificate's signature");
+               return "unable to decrypt certificate's signature";
        case X509_V_ERR_UNABLE_TO_DECRYPT_CRL_SIGNATURE:
-               return("unable to decrypt CRL's signature");
+               return "unable to decrypt CRL's signature";
        case X509_V_ERR_UNABLE_TO_DECODE_ISSUER_PUBLIC_KEY:
-               return("unable to decode issuer public key");
+               return "unable to decode issuer public key";
        case X509_V_ERR_CERT_SIGNATURE_FAILURE:
-               return("certificate signature failure");
+               return "certificate signature failure";
        case X509_V_ERR_CRL_SIGNATURE_FAILURE:
-               return("CRL signature failure");
+               return "CRL signature failure";
        case X509_V_ERR_CERT_NOT_YET_VALID:
-               return("certificate is not yet valid");
+               return "certificate is not yet valid";
        case X509_V_ERR_CRL_NOT_YET_VALID:
-               return("CRL is not yet valid");
+               return "CRL is not yet valid";
        case X509_V_ERR_CERT_HAS_EXPIRED:
-               return("certificate has expired");
+               return "certificate has expired";
        case X509_V_ERR_CRL_HAS_EXPIRED:
-               return("CRL has expired");
+               return "CRL has expired";
        case X509_V_ERR_ERROR_IN_CERT_NOT_BEFORE_FIELD:
-               return("format error in certificate's notBefore field");
+               return "format error in certificate's notBefore field";
        case X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD:
-               return("format error in certificate's notAfter field");
+               return "format error in certificate's notAfter field";
        case X509_V_ERR_ERROR_IN_CRL_LAST_UPDATE_FIELD:
-               return("format error in CRL's lastUpdate field");
+               return "format error in CRL's lastUpdate field";
        case X509_V_ERR_ERROR_IN_CRL_NEXT_UPDATE_FIELD:
-               return("format error in CRL's nextUpdate field");
+               return "format error in CRL's nextUpdate field";
        case X509_V_ERR_OUT_OF_MEM:
-               return("out of memory");
+               return "out of memory";
        case X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT:
-               return("self signed certificate");
+               return "self signed certificate";
        case X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN:
-               return("self signed certificate in certificate chain");
+               return "self signed certificate in certificate chain";
        case X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY:
-               return("unable to get local issuer certificate");
+               return "unable to get local issuer certificate";
        case X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE:
-               return("unable to verify the first certificate");
+               return "unable to verify the first certificate";
        case X509_V_ERR_CERT_CHAIN_TOO_LONG:
-               return("certificate chain too long");
+               return "certificate chain too long";
        case X509_V_ERR_CERT_REVOKED:
-               return("certificate revoked");
+               return "certificate revoked";
        case X509_V_ERR_INVALID_CA:
-               return ("invalid CA certificate");
+               return  "invalid CA certificate";
        case X509_V_ERR_INVALID_NON_CA:
-               return ("invalid non-CA certificate (has CA markings)");
+               return  "invalid non-CA certificate (has CA markings)";
        case X509_V_ERR_PATH_LENGTH_EXCEEDED:
-               return ("path length constraint exceeded");
+               return  "path length constraint exceeded";
        case X509_V_ERR_PROXY_PATH_LENGTH_EXCEEDED:
-               return("proxy path length constraint exceeded");
+               return "proxy path length constraint exceeded";
        case X509_V_ERR_PROXY_CERTIFICATES_NOT_ALLOWED:
-               return("proxy certificates not allowed, please set the appropriate flag");
+               return "proxy certificates not allowed, please set the appropriate flag";
        case X509_V_ERR_INVALID_PURPOSE:
-               return ("unsupported certificate purpose");
+               return  "unsupported certificate purpose";
        case X509_V_ERR_CERT_UNTRUSTED:
-               return ("certificate not trusted");
+               return  "certificate not trusted";
        case X509_V_ERR_CERT_REJECTED:
-               return ("certificate rejected");
+               return  "certificate rejected";
        case X509_V_ERR_APPLICATION_VERIFICATION:
-               return("application verification failure");
+               return "application verification failure";
        case X509_V_ERR_SUBJECT_ISSUER_MISMATCH:
-               return("subject issuer mismatch");
+               return "subject issuer mismatch";
        case X509_V_ERR_AKID_SKID_MISMATCH:
-               return("authority and subject key identifier mismatch");
+               return "authority and subject key identifier mismatch";
        case X509_V_ERR_AKID_ISSUER_SERIAL_MISMATCH:
-               return("authority and issuer serial number mismatch");
+               return "authority and issuer serial number mismatch";
        case X509_V_ERR_KEYUSAGE_NO_CERTSIGN:
-               return("key usage does not include certificate signing");
+               return "key usage does not include certificate signing";
        case X509_V_ERR_UNABLE_TO_GET_CRL_ISSUER:
-               return("unable to get CRL issuer certificate");
+               return "unable to get CRL issuer certificate";
        case X509_V_ERR_UNHANDLED_CRITICAL_EXTENSION:
-               return("unhandled critical extension");
+               return "unhandled critical extension";
        case X509_V_ERR_KEYUSAGE_NO_CRL_SIGN:
-               return("key usage does not include CRL signing");
+               return "key usage does not include CRL signing";
        case X509_V_ERR_KEYUSAGE_NO_DIGITAL_SIGNATURE:
-               return("key usage does not include digital signature");
+               return "key usage does not include digital signature";
        case X509_V_ERR_UNHANDLED_CRITICAL_CRL_EXTENSION:
-               return("unhandled critical CRL extension");
+               return "unhandled critical CRL extension";
        case X509_V_ERR_INVALID_EXTENSION:
-               return("invalid or inconsistent certificate extension");
+               return "invalid or inconsistent certificate extension";
        case X509_V_ERR_INVALID_POLICY_EXTENSION:
-               return("invalid or inconsistent certificate policy extension");
+               return "invalid or inconsistent certificate policy extension";
        case X509_V_ERR_NO_EXPLICIT_POLICY:
-               return("no explicit policy");
+               return "no explicit policy";
        case X509_V_ERR_DIFFERENT_CRL_SCOPE:
-               return("Different CRL scope");
+               return "Different CRL scope";
        case X509_V_ERR_UNSUPPORTED_EXTENSION_FEATURE:
-               return("Unsupported extension feature");
+               return "Unsupported extension feature";
        case X509_V_ERR_UNNESTED_RESOURCE:
-               return("RFC 3779 resource not subset of parent's resources");
+               return "RFC 3779 resource not subset of parent's resources";
        case X509_V_ERR_PERMITTED_VIOLATION:
-               return("permitted subtree violation");
+               return "permitted subtree violation";
        case X509_V_ERR_EXCLUDED_VIOLATION:
-               return("excluded subtree violation");
+               return "excluded subtree violation";
        case X509_V_ERR_SUBTREE_MINMAX:
-               return("name constraints minimum and maximum not supported");
+               return "name constraints minimum and maximum not supported";
        case X509_V_ERR_UNSUPPORTED_CONSTRAINT_TYPE:
-               return("unsupported name constraint type");
+               return "unsupported name constraint type";
        case X509_V_ERR_UNSUPPORTED_CONSTRAINT_SYNTAX:
-               return("unsupported or invalid name constraint syntax");
+               return "unsupported or invalid name constraint syntax";
        case X509_V_ERR_UNSUPPORTED_NAME_SYNTAX:
-               return("unsupported or invalid name syntax");
+               return "unsupported or invalid name syntax";
        case X509_V_ERR_CRL_PATH_VALIDATION_ERROR:
-               return("CRL path validation error");
+               return "CRL path validation error";
        case X509_V_ERR_HOSTNAME_MISMATCH:
-               return("Hostname mismatch");
+               return "Hostname mismatch";
        case X509_V_ERR_EMAIL_MISMATCH:
-               return("Email address mismatch");
+               return "Email address mismatch";
        case X509_V_ERR_IP_ADDRESS_MISMATCH:
-               return("IP address mismatch");
+               return "IP address mismatch";
        case X509_V_ERR_INVALID_CALL:
-               return("Invalid certificate verification context");
+               return "Invalid certificate verification context";
        case X509_V_ERR_STORE_LOOKUP:
-               return("Issuer certificate lookup error");
+               return "Issuer certificate lookup error";
        case X509_V_ERR_EE_KEY_TOO_SMALL:
-               return("EE certificate key too weak");
+               return "EE certificate key too weak";
        case X509_V_ERR_CA_KEY_TOO_SMALL:
-               return("CA certificate key too weak");
+               return "CA certificate key too weak";
        case X509_V_ERR_CA_MD_TOO_WEAK:
-               return("CA signature digest algorithm too weak");
-
+               return "CA signature digest algorithm too weak";
        default:
-               return("Unknown certificate verification error");
+               return "Unknown certificate verification error";
        }
 }
 LCRYPTO_ALIAS(X509_verify_cert_error_string)