drm/amdgpu/pm: Fix uninitialized variable agc_btc_response
authorjsg <jsg@openbsd.org>
Mon, 9 Sep 2024 09:12:21 +0000 (09:12 +0000)
committerjsg <jsg@openbsd.org>
Mon, 9 Sep 2024 09:12:21 +0000 (09:12 +0000)
From Ma Jun
3ad44174a5767dbe1dede02b160a4acfa9899d4f in linux-6.6.y/6.6.50
df4409d8a04dd39d7f2aa0c5f528a56b99eaaa13 in mainline linux

sys/dev/pci/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c

index eaab03e..e6c3a6a 100644 (file)
@@ -2361,15 +2361,20 @@ static int vega10_acg_enable(struct pp_hwmgr *hwmgr)
 {
        struct vega10_hwmgr *data = hwmgr->backend;
        uint32_t agc_btc_response;
+       int ret;
 
        if (data->smu_features[GNLD_ACG].supported) {
                if (0 == vega10_enable_smc_features(hwmgr, true,
                                        data->smu_features[GNLD_DPM_PREFETCHER].smu_feature_bitmap))
                        data->smu_features[GNLD_DPM_PREFETCHER].enabled = true;
 
-               smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL);
+               ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL);
+               if (ret)
+                       return ret;
 
-               smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response);
+               ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response);
+               if (ret)
+                       agc_btc_response = 0;
 
                if (1 == agc_btc_response) {
                        if (1 == data->acg_loop_state)