If the two mfts in mft_compare() are the same do not prefer the

first (DIR_VALID) but perfer the 2nd (DIR_TEMP) since this allows
rpki-client to move the equal files from .rrdp back into the valid
repo tree and so there are less unaccounted files for.
Problem noticed by and OK job@

diff --git a/usr.sbin/rpki-client/mft.c b/usr.sbin/rpki-client/mft.c
index 4c87b99..5173ec0 100644 (file)
--- a/usr.sbin/rpki-client/mft.c
+++ b/usr.sbin/rpki-client/mft.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: mft.c,v 1.89 2023/03/13 19:54:36 job Exp $ */
+/*     $OpenBSD: mft.c,v 1.90 2023/04/24 17:11:33 claudio Exp $ */
 /*
  * Copyright (c) 2022 Theo Buehler <tb@openbsd.org>
  * Copyright (c) 2019 Kristaps Dzonsons <kristaps@bsd.lv>
@@ -545,7 +545,7 @@ mft_compare(const struct mft *a, const struct mft *b)
                return 0;
 
        r = strcmp(a->seqnum, b->seqnum);
-       if (r >= 0)     /* a is greater or equal, prefer a */
+       if (r > 0)      /* a is greater, prefer a */
                return 1;
        return 0;
 }