vfs: struct vops: show all members, even if NULL
authorsemarie <semarie@openbsd.org>
Sun, 12 May 2024 16:51:05 +0000 (16:51 +0000)
committersemarie <semarie@openbsd.org>
Sun, 12 May 2024 16:51:05 +0000 (16:51 +0000)
In order to help code maintenance, explicitly add all `struct vops` members with
the current value (if not present, it is NULL), still using the C99 notation.

ok miod@

sys/isofs/udf/udf_vnops.c
sys/kern/vfs_sync.c
sys/ntfs/ntfs_vnops.c

index e557701..244c781 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: udf_vnops.c,v 1.70 2023/04/13 02:19:05 jsg Exp $      */
+/*     $OpenBSD: udf_vnops.c,v 1.71 2024/05/12 16:51:05 semarie Exp $  */
 
 /*
  * Copyright (c) 2001, 2002 Scott Long <scottl@freebsd.org>
@@ -75,7 +75,24 @@ const struct vops udf_vops = {
        .vop_unlock     = udf_unlock,
        .vop_pathconf   = udf_pathconf,
        .vop_islocked   = udf_islocked,
-       .vop_print      = udf_print
+       .vop_print      = udf_print,
+
+       .vop_abortop    = NULL,
+       .vop_advlock    = NULL,
+       .vop_bwrite     = NULL,
+       .vop_create     = NULL,
+       .vop_fsync      = NULL,
+       .vop_link       = NULL,
+       .vop_mknod      = NULL,
+       .vop_remove     = NULL,
+       .vop_rename     = NULL,
+       .vop_revoke     = NULL,
+       .vop_mkdir      = NULL,
+       .vop_rmdir      = NULL,
+       .vop_setattr    = NULL,
+       .vop_symlink    = NULL,
+       .vop_write      = NULL,
+       .vop_kqfilter   = NULL
 };
 
 #define UDF_INVALID_BMAP       -1
index 8108e6d..4412725 100644 (file)
@@ -1,4 +1,4 @@
-/*       $OpenBSD: vfs_sync.c,v 1.70 2024/02/03 18:51:58 beck Exp $  */
+/*       $OpenBSD: vfs_sync.c,v 1.71 2024/05/12 16:51:05 semarie Exp $  */
 
 /*
  *  Portions of this code are:
@@ -220,7 +220,34 @@ const struct vops sync_vops = {
        .vop_lock       = nullop,
        .vop_unlock     = nullop,
        .vop_islocked   = nullop,
-       .vop_print      = sync_print
+       .vop_print      = sync_print,
+
+       .vop_abortop    = NULL,
+       .vop_access     = NULL,
+       .vop_advlock    = NULL,
+       .vop_bmap       = NULL,
+       .vop_bwrite     = NULL,
+       .vop_create     = NULL,
+       .vop_getattr    = NULL,
+       .vop_ioctl      = NULL,
+       .vop_link       = NULL,
+       .vop_lookup     = NULL,
+       .vop_mknod      = NULL,
+       .vop_open       = NULL,
+       .vop_pathconf   = NULL,
+       .vop_read       = NULL,
+       .vop_readdir    = NULL,
+       .vop_readlink   = NULL,
+       .vop_remove     = NULL,
+       .vop_rename     = NULL,
+       .vop_revoke     = NULL,
+       .vop_mkdir      = NULL,
+       .vop_rmdir      = NULL,
+       .vop_setattr    = NULL,
+       .vop_strategy   = NULL,
+       .vop_symlink    = NULL,
+       .vop_write      = NULL,
+       .vop_kqfilter   = NULL
 };
 
 /*
index d239112..af3a989 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: ntfs_vnops.c,v 1.47 2021/10/15 06:30:06 semarie Exp $ */
+/*     $OpenBSD: ntfs_vnops.c,v 1.48 2024/05/12 16:51:05 semarie Exp $ */
 /*     $NetBSD: ntfs_vnops.c,v 1.6 2003/04/10 21:57:26 jdolecek Exp $  */
 
 /*
@@ -681,4 +681,21 @@ const struct vops ntfs_vops = {
        .vop_strategy   = ntfs_strategy,
        .vop_bwrite     = vop_generic_bwrite,
        .vop_read       = ntfs_read,
+
+       .vop_abortop    = NULL,
+       .vop_advlock    = NULL,
+       .vop_create     = NULL,
+       .vop_ioctl      = NULL,
+       .vop_link       = NULL,
+       .vop_mknod      = NULL,
+       .vop_readlink   = NULL,
+       .vop_remove     = NULL,
+       .vop_rename     = NULL,
+       .vop_revoke     = NULL,
+       .vop_mkdir      = NULL,
+       .vop_rmdir      = NULL,
+       .vop_setattr    = NULL,
+       .vop_symlink    = NULL,
+       .vop_write      = NULL,
+       .vop_kqfilter   = NULL
 };