fix misplaced parenthesis inside if-clause. it's harmless and the only issue is
authormestre <mestre@openbsd.org>
Tue, 28 Aug 2018 12:25:53 +0000 (12:25 +0000)
committermestre <mestre@openbsd.org>
Tue, 28 Aug 2018 12:25:53 +0000 (12:25 +0000)
showing an unknown error (since it's not defined) during fatal(), if it ever
an error occurs inside that condition.

OK deraadt@ markus@ djm@

usr.bin/ssh/auth2-pubkey.c

index 0fa0ca2..9bdc359 100644 (file)
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-pubkey.c,v 1.84 2018/08/23 03:01:08 djm Exp $ */
+/* $OpenBSD: auth2-pubkey.c,v 1.85 2018/08/28 12:25:53 mestre Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -174,7 +174,7 @@ userauth_pubkey(struct ssh *ssh)
                    (r = sshbuf_put_cstring(b, authctxt->service)) != 0 ||
                    (r = sshbuf_put_cstring(b, "publickey")) != 0 ||
                    (r = sshbuf_put_u8(b, have_sig)) != 0 ||
-                   (r = sshbuf_put_cstring(b, pkalg) != 0) ||
+                   (r = sshbuf_put_cstring(b, pkalg)) != 0 ||
                    (r = sshbuf_put_string(b, pkblob, blen)) != 0)
                        fatal("%s: build packet failed: %s",
                            __func__, ssh_err(r));