Casting a gid_t to gid_t for a gid_t argument is overkill

diff --git a/sys/ufs/ext2fs/ext2fs_vnops.c b/sys/ufs/ext2fs/ext2fs_vnops.c
index ec46640..974a68f 100644 (file)
--- a/sys/ufs/ext2fs/ext2fs_vnops.c
+++ b/sys/ufs/ext2fs/ext2fs_vnops.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: ext2fs_vnops.c,v 1.69 2014/12/29 05:29:28 miod Exp $  */
+/*     $OpenBSD: ext2fs_vnops.c,v 1.70 2015/01/11 03:05:03 guenther Exp $      */
 /*     $NetBSD: ext2fs_vnops.c,v 1.1 1997/06/11 09:34:09 bouyer Exp $  */
 
 /*
@@ -372,7 +372,7 @@ ext2fs_chown(struct vnode *vp, uid_t uid, gid_t gid, struct ucred *cred, struct
         * the caller must be superuser or the call fails.
         */
        if ((cred->cr_uid != ip->i_e2fs_uid || uid != ip->i_e2fs_uid ||
-               (gid != ip->i_e2fs_gid && !groupmember((gid_t)gid, cred))) &&
+               (gid != ip->i_e2fs_gid && !groupmember(gid, cred))) &&
                (error = suser_ucred(cred)))
                return (error);
        ogid = ip->i_e2fs_gid;

diff --git a/sys/ufs/ufs/ufs_vnops.c b/sys/ufs/ufs/ufs_vnops.c
index ae0e0eb..2759497 100644 (file)
--- a/sys/ufs/ufs/ufs_vnops.c
+++ b/sys/ufs/ufs/ufs_vnops.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: ufs_vnops.c,v 1.117 2014/12/29 05:29:28 miod Exp $    */
+/*     $OpenBSD: ufs_vnops.c,v 1.118 2015/01/11 03:05:03 guenther Exp $        */
 /*     $NetBSD: ufs_vnops.c,v 1.18 1996/05/11 18:28:04 mycroft Exp $   */
 
 /*
@@ -511,7 +511,7 @@ ufs_chown(struct vnode *vp, uid_t uid, gid_t gid, struct ucred *cred,
         * the caller must be superuser or the call fails.
         */
        if ((cred->cr_uid != DIP(ip, uid) || uid != DIP(ip, uid) ||
-           (gid != DIP(ip, gid) && !groupmember((gid_t)gid, cred))) &&
+           (gid != DIP(ip, gid) && !groupmember(gid, cred))) &&
            (error = suser_ucred(cred)))
                return (error);
        ogid = DIP(ip, gid);