X509_LOOKUP_shutdown() became a noop.
authortb <tb@openbsd.org>
Wed, 27 Dec 2023 01:55:25 +0000 (01:55 +0000)
committertb <tb@openbsd.org>
Wed, 27 Dec 2023 01:55:25 +0000 (01:55 +0000)
That we are still calling this (NB without error check because heritage),
made coverity unhappy.

CID 471705

lib/libcrypto/x509/x509_lu.c

index 5a8fe96..6bdae0f 100644 (file)
@@ -1,4 +1,4 @@
-/* $OpenBSD: x509_lu.c,v 1.61 2023/12/25 22:14:23 tb Exp $ */
+/* $OpenBSD: x509_lu.c,v 1.62 2023/12/27 01:55:25 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -262,7 +262,6 @@ X509_STORE_free(X509_STORE *store)
        sk = store->get_cert_methods;
        for (i = 0; i < sk_X509_LOOKUP_num(sk); i++) {
                lu = sk_X509_LOOKUP_value(sk, i);
-               X509_LOOKUP_shutdown(lu);
                X509_LOOKUP_free(lu);
        }
        sk_X509_LOOKUP_free(sk);