correctly restore sigprocmask around ppoll()

reported by Tõivo Leedjärv; ok deraadt@

diff --git a/usr.bin/ssh/clientloop.c b/usr.bin/ssh/clientloop.c
index c4b37a7..79bffbc 100644 (file)
--- a/usr.bin/ssh/clientloop.c
+++ b/usr.bin/ssh/clientloop.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: clientloop.c,v 1.404 2024/04/30 02:10:49 djm Exp $ */
+/* $OpenBSD: clientloop.c,v 1.405 2024/04/30 02:14:10 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -1576,7 +1576,7 @@ client_loop(struct ssh *ssh, int have_pty, int escape_char_arg,
                client_wait_until_can_do_something(ssh, &pfd, &npfd_alloc,
                    &npfd_active, channel_did_enqueue, &osigset,
                    &conn_in_ready, &conn_out_ready);
-               if (sigprocmask(SIG_UNBLOCK, &bsigset, &osigset) == -1)
+               if (sigprocmask(SIG_SETMASK, &osigset, NULL) == -1)
                        error_f("osigset sigprocmask: %s", strerror(errno));
 
                if (quit_pending)

diff --git a/usr.bin/ssh/serverloop.c b/usr.bin/ssh/serverloop.c
index c669c02..2e3101e 100644 (file)
--- a/usr.bin/ssh/serverloop.c
+++ b/usr.bin/ssh/serverloop.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: serverloop.c,v 1.237 2023/08/21 04:59:54 djm Exp $ */
+/* $OpenBSD: serverloop.c,v 1.238 2024/04/30 02:14:10 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -374,7 +374,7 @@ server_loop2(struct ssh *ssh, Authctxt *authctxt)
                wait_until_can_do_something(ssh, connection_in, connection_out,
                    &pfd, &npfd_alloc, &npfd_active, &osigset,
                    &conn_in_ready, &conn_out_ready);
-               if (sigprocmask(SIG_UNBLOCK, &bsigset, &osigset) == -1)
+               if (sigprocmask(SIG_SETMASK, &osigset, NULL) == -1)
                        error_f("osigset sigprocmask: %s", strerror(errno));
 
                if (received_sigterm) {