Remove the bcmmbox_write(BCMMBOX_CHANPM, ...) call in bcmmbox_attach().

This command locks up my RaspberryPi 4 while it seems to have no effect
for other devices. First of all u-boot will already enable power for us
plus it seems that more is needed than just this write to be really
effective. Why my rpi4 locks up is still unclear but this is now a
pure u-boot issue.

Tested by kettenis@ on his working rpi4 and rpi2
OK kettenis@

diff --git a/sys/dev/fdt/bcm2835_mbox.c b/sys/dev/fdt/bcm2835_mbox.c
index 65114d8..c58741d 100644 (file)
--- a/sys/dev/fdt/bcm2835_mbox.c
+++ b/sys/dev/fdt/bcm2835_mbox.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: bcm2835_mbox.c,v 1.4 2022/08/27 20:31:45 mglocker Exp $ */
+/*     $OpenBSD: bcm2835_mbox.c,v 1.5 2024/05/28 09:19:04 claudio Exp $ */
 
 /*
  * Copyright (c) 2020 Tobias Heider <tobhe@openbsd.org>
@@ -153,15 +153,6 @@ bcmmbox_attach(struct device *parent, struct device *self, void *aux)
 
        printf("\n");
 
-       bcmmbox_write(BCMMBOX_CHANPM, (
-           (1 << VCPROP_POWER_SDCARD) |
-           (1 << VCPROP_POWER_UART0) |
-           (1 << VCPROP_POWER_USB) |
-           (1 << VCPROP_POWER_I2C0) |
-           (1 << VCPROP_POWER_I2C1) |
-           (1 << VCPROP_POWER_SPI) |
-           0) << 4);
-
        return;
 
  clean_dmamap: