Free title earlier, from Alexis Hildebrandt.

diff --git a/usr.bin/tmux/cmd-display-menu.c b/usr.bin/tmux/cmd-display-menu.c
index da30e52..712524c 100644 (file)
--- a/usr.bin/tmux/cmd-display-menu.c
+++ b/usr.bin/tmux/cmd-display-menu.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: cmd-display-menu.c,v 1.39 2023/03/15 19:23:22 nicm Exp $ */
+/* $OpenBSD: cmd-display-menu.c,v 1.40 2023/08/07 10:52:00 nicm Exp $ */
 
 /*
  * Copyright (c) 2019 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -316,6 +316,7 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
        else
                title = xstrdup("");
        menu = menu_create(title);
+       free(title);
 
        for (i = 0; i != count; /* nothing */) {
                name = args_string(args, i++);
@@ -326,7 +327,6 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
 
                if (count - i < 2) {
                        cmdq_error(item, "not enough arguments");
-                       free(title);
                        menu_free(menu);
                        return (CMD_RETURN_ERROR);
                }
@@ -338,7 +338,6 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
 
                menu_add_item(menu, &menu_item, item, tc, target);
        }
-       free(title);
        if (menu == NULL) {
                cmdq_error(item, "invalid menu arguments");
                return (CMD_RETURN_ERROR);