Do not pass VM name directly to setproctitle format string.
authorstefan <stefan@openbsd.org>
Mon, 1 Aug 2016 16:32:10 +0000 (16:32 +0000)
committerstefan <stefan@openbsd.org>
Mon, 1 Aug 2016 16:32:10 +0000 (16:32 +0000)
Use a secure idiom instead.
ok mlarkin@

usr.sbin/vmd/vmm.c

index 59403d5..cb0af49 100644 (file)
@@ -1,4 +1,4 @@
-/*     $OpenBSD: vmm.c,v 1.34 2016/07/29 16:36:51 stefan Exp $ */
+/*     $OpenBSD: vmm.c,v 1.35 2016/08/01 16:32:10 stefan Exp $ */
 
 /*
  * Copyright (c) 2015 Mike Larkin <mlarkin@openbsd.org>
@@ -529,7 +529,7 @@ start_vm(struct imsg *imsg, uint32_t *id)
                return (0);
        } else {
                /* Child */
-               setproctitle(vcp->vcp_name);
+               setproctitle("%s", vcp->vcp_name);
                log_procinit(vcp->vcp_name);
 
                create_memory_map(vcp);