fix decoding of X.509 subject name; from Leif Thuresson via bz3327
authordjm <djm@openbsd.org>
Fri, 25 Jun 2021 06:30:22 +0000 (06:30 +0000)
committerdjm <djm@openbsd.org>
Fri, 25 Jun 2021 06:30:22 +0000 (06:30 +0000)
ok markus@

usr.bin/ssh/ssh-pkcs11.c

index cc8ab3a..6287c66 100644 (file)
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-pkcs11.c,v 1.52 2020/11/22 22:38:26 djm Exp $ */
+/* $OpenBSD: ssh-pkcs11.c,v 1.53 2021/06/25 06:30:22 djm Exp $ */
 /*
  * Copyright (c) 2010 Markus Friedl.  All rights reserved.
  * Copyright (c) 2014 Pedro Martelletto. All rights reserved.
@@ -956,7 +956,7 @@ pkcs11_fetch_x509_pubkey(struct pkcs11_provider *p, CK_ULONG slotidx,
        }
 
        /* Decode DER-encoded cert subject */
-       cp = cert_attr[2].pValue;
+       cp = cert_attr[1].pValue;
        if ((x509_name = d2i_X509_NAME(NULL, &cp,
            cert_attr[1].ulValueLen)) == NULL ||
            (subject = X509_NAME_oneline(x509_name, NULL, 0)) == NULL)