Don't print references to Intel's website for downloading firmware
authorjcs <jcs@openbsd.org>
Thu, 9 Sep 2021 02:23:14 +0000 (02:23 +0000)
committerjcs <jcs@openbsd.org>
Thu, 9 Sep 2021 02:23:14 +0000 (02:23 +0000)
when loading fails, it will just confuse people

ok jsg

sys/dev/pci/drm/i915/display/intel_csr.c
sys/dev/pci/drm/i915/gt/uc/intel_uc_fw.c

index f173fe3..21b4e7a 100644 (file)
@@ -657,8 +657,10 @@ static void csr_load_work_fn(struct work_struct *work)
                           "Failed to load DMC firmware %s."
                           " Disabling runtime power management.\n",
                           csr->fw_path);
+#ifdef __linux__
                drm_notice(&dev_priv->drm, "DMC firmware homepage: %s",
                           INTEL_UC_FIRMWARE_URL);
+#endif
        }
 
        release_firmware(fw);
index d0c8238..36d554d 100644 (file)
@@ -391,8 +391,10 @@ fail:
 
        drm_notice(&i915->drm, "%s firmware %s: fetch failed with error %d\n",
                   intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
+#ifdef __linux__
        drm_info(&i915->drm, "%s firmware(s) can be downloaded from %s\n",
                 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
+#endif
 
        release_firmware(fw);           /* OK even if fw is NULL */
        return err;