replace cast with call to sshbuf_mutable_ptr(); ok djm@

diff --git a/usr.bin/ssh/authfd.c b/usr.bin/ssh/authfd.c
index c1a4f0b..1c36323 100644 (file)
--- a/usr.bin/ssh/authfd.c
+++ b/usr.bin/ssh/authfd.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: authfd.c,v 1.110 2018/07/03 11:39:54 djm Exp $ */
+/* $OpenBSD: authfd.c,v 1.111 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -131,7 +131,7 @@ ssh_request_reply(int sock, struct sshbuf *request, struct sshbuf *reply)
 
        /* Send the length and then the packet to the agent. */
        if (atomicio(vwrite, sock, buf, 4) != 4 ||
-           atomicio(vwrite, sock, (u_char *)sshbuf_ptr(request),
+           atomicio(vwrite, sock, sshbuf_mutable_ptr(request),
            sshbuf_len(request)) != sshbuf_len(request))
                return SSH_ERR_AGENT_COMMUNICATION;
        /*

diff --git a/usr.bin/ssh/authfile.c b/usr.bin/ssh/authfile.c
index 1a420cc..6309e18 100644 (file)
--- a/usr.bin/ssh/authfile.c
+++ b/usr.bin/ssh/authfile.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: authfile.c,v 1.129 2018/06/06 18:29:18 markus Exp $ */
+/* $OpenBSD: authfile.c,v 1.130 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Copyright (c) 2000, 2013 Markus Friedl.  All rights reserved.
  *
@@ -57,7 +57,7 @@ sshkey_save_private_blob(struct sshbuf *keybuf, const char *filename)
 
        if ((fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, 0600)) < 0)
                return SSH_ERR_SYSTEM_ERROR;
-       if (atomicio(vwrite, fd, (u_char *)sshbuf_ptr(keybuf),
+       if (atomicio(vwrite, fd, sshbuf_mutable_ptr(keybuf),
            sshbuf_len(keybuf)) != sshbuf_len(keybuf)) {
                oerrno = errno;
                close(fd);

diff --git a/usr.bin/ssh/msg.c b/usr.bin/ssh/msg.c
index cf73ba4..eb6ce75 100644 (file)
--- a/usr.bin/ssh/msg.c
+++ b/usr.bin/ssh/msg.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: msg.c,v 1.16 2015/01/15 09:40:00 djm Exp $ */
+/* $OpenBSD: msg.c,v 1.17 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Copyright (c) 2002 Markus Friedl.  All rights reserved.
  *
@@ -53,7 +53,7 @@ ssh_msg_send(int fd, u_char type, struct sshbuf *m)
                error("ssh_msg_send: write");
                return (-1);
        }
-       if (atomicio(vwrite, fd, (u_char *)sshbuf_ptr(m), mlen) != mlen) {
+       if (atomicio(vwrite, fd, sshbuf_mutable_ptr(m), mlen) != mlen) {
                error("ssh_msg_send: write");
                return (-1);
        }

diff --git a/usr.bin/ssh/ssh-keygen.c b/usr.bin/ssh/ssh-keygen.c
index 80e488e..2c3a6dd 100644 (file)
--- a/usr.bin/ssh/ssh-keygen.c
+++ b/usr.bin/ssh/ssh-keygen.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-keygen.c,v 1.317 2018/06/06 18:29:18 markus Exp $ */
+/* $OpenBSD: ssh-keygen.c,v 1.318 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1994 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -2240,7 +2240,7 @@ do_gen_krl(struct passwd *pw, int updating, int argc, char **argv)
                fatal("Couldn't generate KRL");
        if ((fd = open(identity_file, O_WRONLY|O_CREAT|O_TRUNC, 0644)) == -1)
                fatal("open %s: %s", identity_file, strerror(errno));
-       if (atomicio(vwrite, fd, (void *)sshbuf_ptr(kbuf), sshbuf_len(kbuf)) !=
+       if (atomicio(vwrite, fd, sshbuf_mutable_ptr(kbuf), sshbuf_len(kbuf)) !=
            sshbuf_len(kbuf))
                fatal("write %s: %s", identity_file, strerror(errno));
        close(fd);

diff --git a/usr.bin/ssh/ssh-pkcs11-client.c b/usr.bin/ssh/ssh-pkcs11-client.c
index 6d3cda9..1ab6985 100644 (file)
--- a/usr.bin/ssh/ssh-pkcs11-client.c
+++ b/usr.bin/ssh/ssh-pkcs11-client.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-pkcs11-client.c,v 1.9 2018/07/09 20:39:28 markus Exp $ */
+/* $OpenBSD: ssh-pkcs11-client.c,v 1.10 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Copyright (c) 2010 Markus Friedl.  All rights reserved.
  *
@@ -51,7 +51,7 @@ send_msg(struct sshbuf *m)
 
        POKE_U32(buf, mlen);
        if (atomicio(vwrite, fd, buf, 4) != 4 ||
-           atomicio(vwrite, fd, (u_char *)sshbuf_ptr(m),
+           atomicio(vwrite, fd, sshbuf_mutable_ptr(m),
            sshbuf_len(m)) != sshbuf_len(m))
                error("write to helper failed");
        if ((r = sshbuf_consume(m, mlen)) != 0)

diff --git a/usr.bin/ssh/sshkey-xmss.c b/usr.bin/ssh/sshkey-xmss.c
index b5d40ac..c891fc0 100644 (file)
--- a/usr.bin/ssh/sshkey-xmss.c
+++ b/usr.bin/ssh/sshkey-xmss.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sshkey-xmss.c,v 1.2 2018/04/10 00:10:49 djm Exp $ */
+/* $OpenBSD: sshkey-xmss.c,v 1.3 2018/07/09 21:59:10 markus Exp $ */
 /*
  * Copyright (c) 2017 Markus Friedl.  All rights reserved.
  *
@@ -619,7 +619,7 @@ sshkey_xmss_update_state(const struct sshkey *k, sshkey_printfn *pr)
                close(fd);
                goto done;
        }
-       if (atomicio(vwrite, fd, (void *)sshbuf_ptr(enc), sshbuf_len(enc)) !=
+       if (atomicio(vwrite, fd, sshbuf_mutable_ptr(enc), sshbuf_len(enc)) !=
            sshbuf_len(enc)) {
                ret = SSH_ERR_SYSTEM_ERROR;
                PRINT("%s: write new state file data: %s", __func__, nstatefile);