avoid loosing return value from copyin, and properly return it.

initial patch from me, reworked by oga@.

found by LLVM/Clang Static Analyzer.

ok oga@

diff --git a/sys/dev/pci/drm/drm_drawable.c b/sys/dev/pci/drm/drm_drawable.c
index be4444b..4d6e192 100644 (file)
--- a/sys/dev/pci/drm/drm_drawable.c
+++ b/sys/dev/pci/drm/drm_drawable.c
@@ -171,7 +171,7 @@ drm_update_draw(struct drm_device *dev, void *data, struct drm_file *file_priv)
                /* For some reason the pointer arg is unsigned long long. */
                ret = copyin((void *)(intptr_t)update->data, info->rects,
                    sizeof(*info->rects) * info->num_rects);
-               DRM_SPINUNLOCK(&dev->drw_lock);
+               break;
        default:
                ret =  EINVAL;
        }