Remove tls_buffer_set_data() and remove/revise callers.
authorjsing <jsing@openbsd.org>
Wed, 20 Jul 2022 06:32:24 +0000 (06:32 +0000)
committerjsing <jsing@openbsd.org>
Wed, 20 Jul 2022 06:32:24 +0000 (06:32 +0000)
commitfc718d1d888c5fb1425013853bfa64794fdcb8ad
tree2e746c1fc0efc348fcd5a91dbfc50dab8e5d9598
parent622f173fe044608da8e31c2322e322ee7e98b0b7
Remove tls_buffer_set_data() and remove/revise callers.

There is no way that tls_buffer_set_data() can currently work in
conjunction with tls_buffer_expand(). This fact is currently hidden by the
way that PHH works, which reads the same data from the record layer (which
it needs to do anyway, since we may not have all of the handshake message
in a single record).

Since this is broken, mop it up and change the PHH callback to not provide
the record data.

ok beck@ tb@
lib/libssl/tls13_handshake_msg.c
lib/libssl/tls13_internal.h
lib/libssl/tls13_lib.c
lib/libssl/tls13_record_layer.c
lib/libssl/tls_buffer.c
lib/libssl/tls_internal.h