Don't create ICMP states on reply packets unless tracking states sloppy
authormikeb <mikeb@openbsd.org>
Tue, 26 May 2015 16:17:51 +0000 (16:17 +0000)
committermikeb <mikeb@openbsd.org>
Tue, 26 May 2015 16:17:51 +0000 (16:17 +0000)
commite93f5c0a6e204e891614db09fc070bce2b47bf8c
treee7148e769d62ec5c444870d23ef380bff5796cc7
parente9188d0dfea386f14091514d8cc5403908bb5a22
Don't create ICMP states on reply packets unless tracking states sloppy

Since we've strengthened the ICMP state matching procedure during lookup
to only match packets against states set up in a particular direction, we
need to make sure we don't create states on packets that would otherwise
be flowing in the direction opposite to the direction of the state and
prevent further packets from matching the created state due to strict
rules imposed by the ICMP direction check.

Problem reported by Alexandr Nedvedicky, alexandr.nedvedicky-at-oracle.com.
Discussed with reyk@;  OK henning
sys/net/pf.c