Remove EVP_PKEY2PKCS8_broken() and PKCS8_set_broken()
authortb <tb@openbsd.org>
Fri, 24 Aug 2018 20:07:41 +0000 (20:07 +0000)
committertb <tb@openbsd.org>
Fri, 24 Aug 2018 20:07:41 +0000 (20:07 +0000)
commite4a8fc546be24a3cbef6f62318a8ec2526d9a289
tree4b37eae35a3f9073b320373cf6420a5f80243a20
parent84547d1c412cc1fdb25e2b559d8d41230ebbf039
Remove EVP_PKEY2PKCS8_broken() and PKCS8_set_broken()

Provide PKCS8_pkey_add1_attr_by_NID() and PKCS8_pkey_get0_attrs().
Remove the whole broken code and simplify pkcs8_priv_key_info_st
accordingly. Based on OpenSSL commit
54dbf42398e23349b59f258a3dd60387bbc5ba13 plus some const that was
added later.

tested in a bulk build by sthen
ok jsing
lib/libcrypto/Symbols.list
lib/libcrypto/asn1/p8_pkey.c
lib/libcrypto/evp/evp_pkey.c
lib/libcrypto/pkcs12/p12_attr.c
lib/libcrypto/x509/x509.h