Remove the OK and ERR macros. They obfuscate the code and don't
authortedu <tedu@openbsd.org>
Fri, 23 Jan 2015 02:37:25 +0000 (02:37 +0000)
committertedu <tedu@openbsd.org>
Fri, 23 Jan 2015 02:37:25 +0000 (02:37 +0000)
commitdd2fc19c1bcbf43e5acf03814c79377818cdc2e1
tree55354534d03dbaddff98fd0a20a05abdf4b84fe0
parent913a7b1918e07d0317cbc51ddaa5225428f2e0c2
Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt
usr.sbin/cron/atrun.c
usr.sbin/cron/crontab.c
usr.sbin/cron/database.c
usr.sbin/cron/do_command.c
usr.sbin/cron/entry.c
usr.sbin/cron/env.c
usr.sbin/cron/macros.h
usr.sbin/cron/misc.c
usr.sbin/cron/user.c