artulab
projects / openbsd / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c2364f2) | patch
Fix a modify after free error in kroute_remove()
authorclaudio <claudio@openbsd.org>
Wed, 3 Aug 2022 08:16:05 +0000 (08:16 +0000)
committerclaudio <claudio@openbsd.org>
Wed, 3 Aug 2022 08:16:05 +0000 (08:16 +0000)
commit348cd8fe5495fcdbdea25ec60d781593f7ff4785
tree5416e8b98d275980465cd5a8f6c789a44789c24ctree | snapshot
parentc2364f2ab38e3255986defad064283e6e86862e7commit | diff
Fix a modify after free error in kroute_remove()

knexthop_validate() will modify the kroute the nexthop points to.
Because of this knexthop_validate() needs to be called before the
to be removed kroute is freed. Move the code into kroute_remove[46]
so the order is correct.
Problem found and fix tested by sthen@.
OK sthen@ tb@
usr.sbin/bgpd/kroute.c diff | blob | history
OpenBSD src
by Ahmet Artu Yildirim