Revert lock changes inside ifioctl_get()
authorkn <kn@openbsd.org>
Tue, 8 Nov 2022 21:07:33 +0000 (21:07 +0000)
committerkn <kn@openbsd.org>
Tue, 8 Nov 2022 21:07:33 +0000 (21:07 +0000)
commit33f9018f7f6efe3796b02de759358e523c778c5e
treef5ad43dcc0c2b187ab4d5e433ea82f8c2df6c2a0
parentda1f63bfa4e8018538ebe17e29c91e146fb6a3d6
Revert lock changes inside ifioctl_get()

WITNESS isn't happy with r1.667 "Push kernel lock into ifioctl_get()", so
revert it (including r1.668 and r1.669 depending on it):

witness: userret: returning with the following locks held:
exclusive kernel_lock &kernel_lock r = 0 (0xffffffff82455f58)
#0  witness_lock+0x311
#1  ifioctl_get+0x2e
#2  sys_ioctl+0x2c4
#3  syscall+0x384
#4  Xsyscall+0x128
panic: witness_warn
Stopped at      db_enter+0x10:  popq    %rbp
    TID    PID    UID     PRFLAGS     PFLAGS  CPU  COMMAND
* 70588  52613      0         0x3          0    4K pfctl

So back to the drawing board while leaving documentation bits (r1.670).
Thanks Hrvoje.
sys/net/if.c