If an invalid varbindlist was returned by a backend we would call
authormartijn <martijn@openbsd.org>
Fri, 27 Oct 2023 10:32:11 +0000 (10:32 +0000)
committermartijn <martijn@openbsd.org>
Fri, 27 Oct 2023 10:32:11 +0000 (10:32 +0000)
commit06c02db800a6ceda0fa52ae1e0fce2929a7eca74
treebdeb2d93008d076339dbf250ec48e37e5c849a88
parente024f79d1742353cf5680106c4fbd19da1b0b060
If an invalid varbindlist was returned by a backend we would call
appl_request_upstream_resolve() twice where the first call would already
return a reply and free the upstream request, leading to a use after
free.
Make appl_request_downstream_free() call appl_request_upstream_resolve()
unconditionally and remove the call from appl_response().

OK tb@
usr.sbin/snmpd/application.c